Skip to content

feat: add union on ExtDTreeMap/ExtTreeMap/ExtTreeSet #11070

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 20 commits into from
Nov 11, 2025
Merged

feat: add union on ExtDTreeMap/ExtTreeMap/ExtTreeSet #11070

merged 20 commits into from
Nov 11, 2025

Conversation

@wkrozowski
Copy link
Contributor

@wkrozowski wkrozowski commented Nov 3, 2025

This PR adds union operation on ExtDHashMap/ExtHashMap/ExtHashSet nd provides lemmas about union operations.

Stacked on top of #10946.

@github-actions github-actions bot added the toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN label Nov 3, 2025
@leanprover-community-bot
Copy link
Collaborator

leanprover-community-bot commented Nov 3, 2025 •
edited
Loading

Mathlib CI status (docs):

  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase 00e29075f38e5307b404b656805da137e5c52942 --onto 3e86729ee0e11548a47f9b294d5292ada92c0b40. You can force Mathlib CI using the force-mathlib-ci label. (2025-11-03 19:23:08)
  • ❗ Batteries/Mathlib CI will not be attempted unless your PR branches off the nightly-with-mathlib branch. Try git rebase c08fcf6c28aa6b8d500b4ee6fe85c76b658bd13a --onto d47b474e41e4b134239ef70fa3c15778cc771bcf. You can force Mathlib CI using the force-mathlib-ci label. (2025-11-10 15:49:58)

@leanprover-bot
Copy link
Collaborator

leanprover-bot commented Nov 3, 2025 •
edited
Loading

Reference manual CI status:

  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase 00e29075f38e5307b404b656805da137e5c52942 --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-11-03 19:23:10)
  • ❗ Reference manual CI will not be attempted unless your PR branches off the nightly-with-manual branch. Try git rebase c08fcf6c28aa6b8d500b4ee6fe85c76b658bd13a --onto d3dda9f6d4428a906c096067ecb75e432afc4615. You can force reference manual CI using the force-manual-ci label. (2025-11-10 15:50:00)

@wkrozowski wkrozowski marked this pull request as ready for review November 11, 2025 09:02
@wkrozowski wkrozowski requested a review from TwoFX as a code owner November 11, 2025 09:02
@TwoFX TwoFX added the changelog-library Library label Nov 11, 2025
TwoFX
TwoFX approved these changes Nov 11, 2025
View reviewed changes
Copy link
Member

@TwoFX TwoFX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/Std/Data/ExtDHashMap/Basic.lean Outdated

@[induction_eliminator, cases_eliminator, elab_as_elim]
theorem inductionOn {motive : ExtDHashMap α β → Prop} (m : ExtDHashMap α β)
theorem inductionOn {motive : ExtDHashMap α β → Prop} (m : ExtDHashMap α β)
Copy link
Member

@TwoFX TwoFX Nov 11, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

😱

@wkrozowski wkrozowski added this pull request to the merge queue Nov 11, 2025
Merged via the queue into leanprover:master with commit e0af512 Nov 11, 2025
14 checks passed
@wkrozowski wkrozowski deleted the wojciech/extdtreemap_union branch November 11, 2025 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@TwoFX TwoFX TwoFX approved these changes

Assignees

No one assigned

Labels

changelog-library Library toolchain-available A toolchain is available for this PR, at leanprover/lean4-pr-releases:pr-release-NNNN

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@wkrozowski @leanprover-community-bot @leanprover-bot @TwoFX